diff options
author | axtloss <axtlos@getcryst.al> | 2023-05-15 22:45:30 +0200 |
---|---|---|
committer | axtloss <axtlos@getcryst.al> | 2023-05-15 22:45:30 +0200 |
commit | a4fa9a8622ddf1226db706556db9e96853ea4e28 (patch) | |
tree | 7fb5f62509b6ec038303025259a8e71874b52ae1 /src/main/java/io/github | |
parent | 9736e92073502adcfd466a629f10464f518e2c15 (diff) | |
download | jshipit-a4fa9a8622ddf1226db706556db9e96853ea4e28.tar.gz jshipit-a4fa9a8622ddf1226db706556db9e96853ea4e28.tar.bz2 |
fix some warnings
Intellij when unnecessary .toString: "boohoo pls remove :("
Intellij when literally my code: "yeah that's fine :D"
Diffstat (limited to 'src/main/java/io/github')
-rw-r--r-- | src/main/java/io/github/jshipit/BlobDownloader.java | 2 | ||||
-rwxr-xr-x | src/main/java/io/github/jshipit/DockerAPIHelper.java | 8 | ||||
-rwxr-xr-x | src/main/java/io/github/jshipit/JshipIT.java | 14 | ||||
-rw-r--r-- | src/main/java/io/github/jshipit/Main.java | 2 |
4 files changed, 8 insertions, 18 deletions
diff --git a/src/main/java/io/github/jshipit/BlobDownloader.java b/src/main/java/io/github/jshipit/BlobDownloader.java index 5fa3959..6a17057 100644 --- a/src/main/java/io/github/jshipit/BlobDownloader.java +++ b/src/main/java/io/github/jshipit/BlobDownloader.java @@ -26,7 +26,7 @@ public class BlobDownloader extends Thread { URL url_obj = null; try { url_obj = new URI(this.url).toURL(); - System.out.println(url_obj.toString()); + System.out.println(url_obj); } catch(URISyntaxException | MalformedURLException e) { System.out.println("URISyntaxException | MalformedURLException"); e.printStackTrace(); diff --git a/src/main/java/io/github/jshipit/DockerAPIHelper.java b/src/main/java/io/github/jshipit/DockerAPIHelper.java index 127f90e..56bfeca 100755 --- a/src/main/java/io/github/jshipit/DockerAPIHelper.java +++ b/src/main/java/io/github/jshipit/DockerAPIHelper.java @@ -3,11 +3,9 @@ package io.github.jshipit; import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.ObjectMapper; -import me.tongfei.progressbar.*; import java.io.*; import java.net.*; -import java.sql.Blob; import java.util.List; import java.util.Map; import java.util.Scanner; @@ -46,7 +44,7 @@ public class DockerAPIHelper { URL url_obj = null; try { url_obj = new URI("https://"+this.apiRepo+"/v2/").toURL(); - System.out.println(url_obj.toString()); + System.out.println(url_obj); } catch (URISyntaxException | MalformedURLException e) { e.printStackTrace(); } @@ -70,7 +68,7 @@ public class DockerAPIHelper { URL url_obj = null; try { url_obj = new URI(this.authURL + "?scope=repository:" + this.repository + "/" + this.image + ":pull" + "&service=" + this.authService).toURL(); - System.out.println(url_obj.toString()); + System.out.println(url_obj); } catch (URISyntaxException | MalformedURLException e) { System.out.println("URISyntaxException | MalformedURLException"); e.printStackTrace(); @@ -105,7 +103,7 @@ public class DockerAPIHelper { URL url_obj = null; try { url_obj = new URI("https://" + this.apiRepo + "/v2/" + this.repository + "/" + this.image + "/manifests/"+this.tag).toURL(); - System.out.println(url_obj.toString()); + System.out.println(url_obj); } catch(URISyntaxException | MalformedURLException e) { System.out.println("URISyntaxException | MalformedURLException"); e.printStackTrace(); diff --git a/src/main/java/io/github/jshipit/JshipIT.java b/src/main/java/io/github/jshipit/JshipIT.java index 30065a0..4044a39 100755 --- a/src/main/java/io/github/jshipit/JshipIT.java +++ b/src/main/java/io/github/jshipit/JshipIT.java @@ -8,19 +8,14 @@ import java.nio.file.Path; public class JshipIT { - public int finishedCount; - public int downloadThreads; - - public JshipIT(String[] args) { + public JshipIT() { DockerAPIHelper api = new DockerAPIHelper("registry.getcryst.al","crystal/misc", "docker", "latest"); JsonNode manifest = null; System.out.println("API Token: " + api.getApiToken()); try { manifest = api.fetchManifestJson(); - } catch (IOException e) { - - } + } catch (IOException ignored) {} // Proper error handling is bloat System.out.println("Manifest: " + manifest); @@ -33,15 +28,12 @@ public class JshipIT { return; } - finishedCount = 0; - downloadThreads = 0; - + assert manifest != null; JsonNode layers = manifest.get("layers"); for (JsonNode layer : layers) { System.out.println("Layer: " + layer); try { api.fetchBlob(layer.get("digest").asText(), path.toString()); - downloadThreads = downloadThreads+1; } catch (IOException e) { e.printStackTrace(); } diff --git a/src/main/java/io/github/jshipit/Main.java b/src/main/java/io/github/jshipit/Main.java index 9de8b6d..bb33fa5 100644 --- a/src/main/java/io/github/jshipit/Main.java +++ b/src/main/java/io/github/jshipit/Main.java @@ -3,7 +3,7 @@ package io.github.jshipit; public class Main { public static void main(String[] args) { - JshipIT prog = new JshipIT(args); // I HATE STATIC FUNCTIONS + new JshipIT(); // I HATE STATIC FUNCTIONS } } |